Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tso: introduce the AllocatorManager #2859

Merged
merged 13 commits into from
Sep 2, 2020
Merged

tso: introduce the AllocatorManager #2859

merged 13 commits into from
Sep 2, 2020

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 28, 2020 •
edited
Loading

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Part of #2759. Resolve #2858.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Introduce the AllocatorManager to manage all TSO Allocators a PD server will hold.

@JmPotato JmPotato added component/tso Timestamp Oracle. component/election Election related logic. labels Aug 28, 2020
@JmPotato JmPotato linked an issue Aug 28, 2020 that may be closed by this pull request
Provide a new way to manage TSO Allocators #2858
Closed
@JmPotato
Update err msg
2f47357 
Signed-off-by: JmPotato <[email protected]>
rleungx
rleungx reviewed Aug 28, 2020
View reviewed changes
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
disksing
disksing reviewed Aug 28, 2020
View reviewed changes
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
@JmPotato
Address comments
fe47936 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Copy link
Member Author

/run-all-tests

Yisaer
Yisaer reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
Yisaer
Yisaer previously approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
@Yisaer Yisaer dismissed their stale review August 31, 2020 09:12

find error

@JmPotato
Address comments
d00efd3 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Copy link
Member Author

One more review needed. PTAL @disksing @rleungx

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 1, 2020
Yisaer
Yisaer approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/tso/allocator_manager.go Outdated Show resolved Hide resolved
lhy1024
lhy1024 reviewed Sep 1, 2020
View reviewed changes
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
rleungx
rleungx reviewed Sep 1, 2020
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Show resolved Hide resolved
@JmPotato JmPotato mentioned this pull request Sep 2, 2020
Closed
16 tasks
@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2020

/run-all-tests

@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2020

/run-all-tests

@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2020

/run-all-tests

@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2020

/run-unit-test

@JmPotato JmPotato merged commit 7e7ea1a into tikv:master Sep 2, 2020
@JmPotato JmPotato deleted the update_leadership branch September 2, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@lhy1024 lhy1024 lhy1024 left review comments

@Yisaer Yisaer Yisaer approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@disksing disksing disksing approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
component/election Election related logic. component/tso Timestamp Oracle. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a new way to manage TSO Allocators
6 participants
@JmPotato @disksing @Yisaer @lhy1024 @rleungx @ti-srebot